Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add packageManager field #389

Merged
merged 4 commits into from
Apr 19, 2023
Merged

chore: add packageManager field #389

merged 4 commits into from
Apr 19, 2023

Conversation

sxzz
Copy link
Contributor

@sxzz sxzz commented Apr 19, 2023 •
edited
Loading

to pin pnpm@8

PR-Codex overview

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 30853f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 19, 2023

@sxzz is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@fubhy
Copy link
Collaborator

fubhy commented Apr 19, 2023 •
edited
Loading

Just wondering... Should we pin this to 8.3.1 already?

I find myself constantly switching between v7 and v8 to not create unrelated lock file changes when working on different OSS projects. Would be great to bump this to v8 imho.

@sxzz sxzz requested a review from fubhy April 19, 2023 14:06
@sxzz
Copy link
Contributor Author

sxzz commented Apr 19, 2023

@fubhy Done

@socket-security
Copy link

socket-security bot commented Apr 19, 2023 •
edited
Loading

New dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@size-limit/[email protected] None +60 ai
[email protected] None +0 heineiuo
@wagmi/[email protected] eval, filesystem, environment +70 awkweb
[email protected] eval, filesystem, shell, environment +44 oreanno
[email protected] shell, environment +4 ai
[email protected] environment +6 gnoff
@vitest/[email protected] eval, filesystem +50 oreanno
@vitejs/[email protected] environment +186 vitebot
[email protected] filesystem, environment +18 adamwathan
@wagmi/[email protected] None +0 jmoxey
[email protected] None +0 awkweb

@fubhy
Copy link
Collaborator

fubhy commented Apr 19, 2023

Great. Looks good imho.

tmm
tmm reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to make sure pnpm versions match in the CI workflows via matrix.pnpm-version.

Hopefully we can just use Corepack with the workflows some day.

@sxzz
Copy link
Contributor Author

sxzz commented Apr 19, 2023

@tmm Done. pnpm/action-setup now will read packageManager field in the package.json

https://github.com/pnpm/action-setup#version

@sxzz sxzz requested a review from tmm April 19, 2023 17:13
@tmm tmm force-pushed the chore/package-manager branch 2 times, most recently from 5ffe6ad to 27aacc2 Compare April 19, 2023 22:45
@vercel
Copy link

vercel bot commented Apr 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 10:57pm
viem-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 10:57pm

@tmm tmm merged commit f6a04b8 into wevm:main Apr 19, 2023
@sxzz sxzz deleted the chore/package-manager branch April 20, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmm tmm tmm approved these changes

@fubhy fubhy fubhy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxzz @fubhy @tmm